From 3fbb2cdb4b82f7f9f4036ab79a820e7fb482edd3 Mon Sep 17 00:00:00 2001 From: HerozDotExe Date: Fri, 27 Mar 2026 12:35:40 +0100 Subject: [PATCH] fix: make modrinth test downloads the java version needed for the pack --- tests/modrinth-java.test.ts.template | 10 +++++----- tests/modrinth.test.ts.template | 17 ++++++++++------- 2 files changed, 15 insertions(+), 12 deletions(-) diff --git a/tests/modrinth-java.test.ts.template b/tests/modrinth-java.test.ts.template index 0d72bd3..850082a 100644 --- a/tests/modrinth-java.test.ts.template +++ b/tests/modrinth-java.test.ts.template @@ -13,11 +13,11 @@ test("launch game", { timeout: 0, tags: ["full", "modrinth"] }, async () => { // const java = await javaManager.use(await getJavaComponent("${version}")) const instance = new Instance({ - auth: offlineAuth("player"), - paths: { root: gameRoot, instance: path.join(gameRoot, "instances", "${modpack_id}") }, - javaExecutable: "${java}", - ram: {max:"4G",min:"4G"} - }, + auth: offlineAuth("player"), + paths: { root: gameRoot, instance: path.join(gameRoot, "instances", "${modpack_id}") }, + javaExecutable: "${java}", + ram: { max: "4G", min: "4G" } + }, await importModrinthModpack("${modpack_url}", "url") ); diff --git a/tests/modrinth.test.ts.template b/tests/modrinth.test.ts.template index b8f6d9d..ea26988 100644 --- a/tests/modrinth.test.ts.template +++ b/tests/modrinth.test.ts.template @@ -10,15 +10,18 @@ const gameRoot = path.join(import.meta.dirname, "..", "temp"); test("launch game", { timeout: 0, tags: ["full", "modrinth"] }, async () => { const javaManager = new RuntimeManager(path.join(gameRoot, "java")); javaManager.on("progress", console.log) - const java = await javaManager.use(await getJavaComponent("${version}")) + const modpack = + await importModrinthModpack("${modpack_url}", "url") + const java = await javaManager.use(await getJavaComponent(modpack.version)) + const instance = new Instance({ - auth: offlineAuth("player"), - paths: { root: gameRoot, instance: path.join(gameRoot, "instances", "${modpack_id}") }, - javaExecutable: java, - ram: {max:"4G",min:"4G"} - }, - await importModrinthModpack("${modpack_url}", "url") + auth: offlineAuth("player"), + paths: { root: gameRoot, instance: path.join(gameRoot, "instances", "${modpack_id}") }, + javaExecutable: java, + ram: { max: "4G", min: "4G" } + }, + modpack ); instance.on("progress", console.log);